Fix condition move: update existing POC instead of creating duplicate#137
Closed
Copilot wants to merge 3 commits intonext-releasefrom
Closed
Fix condition move: update existing POC instead of creating duplicate#137Copilot wants to merge 3 commits intonext-releasefrom
Copilot wants to merge 3 commits intonext-releasefrom
Conversation
…n is moved Agent-Logs-Url: https://github.com/canonical/dashboard/sessions/2c26ce3b-f7d0-4e80-a193-f0df5e5f0201 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix POC movement issue and improve level calculation
Fix condition move: update existing POC instead of creating duplicate
Mar 28, 2026
dwilding
requested changes
Apr 28, 2026
Collaborator
dwilding
left a comment
There was a problem hiding this comment.
Please rebase this onto the next-release branch
Agent-Logs-Url: https://github.com/canonical/dashboard/sessions/e1835332-0813-480b-9f68-b60b5a4b90f1 Co-authored-by: dwilding <1141260+dwilding@users.noreply.github.com>
Contributor
Author
Done — rebased onto |
Collaborator
|
I'm going to close this and look at #136 again after the next release. There's already enough staged for the next release and I don't have time to review more additions this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving a condition from objective A to objective B,
Condition.save()was creating a freshProjectObjectiveConditionfor the new objective while leaving the original POC (with its completion status) orphaned under the old objective. This caused a hidden/displayed POC split where the completion status was never carried over.Changes
framework/models.py—Condition.save()now detects whenobjectiveis being changed on an existing condition. Instead of runningget_or_createagainst the new objective, it calls.update(objective=self.objective)on the existing POCs, preservingstatusin-place. The new/unchanged-objective path also incorporates theCommitmentbackfill logic from thenext-releasebranch, ensuring that new conditions at new levels create matching commitments for all existing project/work-cycle combinations:framework/test_models.py— Addedtest_moving_condition_updates_poc_not_creates_duplicateto assert that after moving a condition: exactly one POC exists, it points to the new objective, and its status is preserved. Also includes thetest_new_condition_with_new_level_backfills_commitmenttest fromnext-releasethat covers the Commitment backfill behaviour.Manual checks
rockcraft.yaml? Remember to use the same version number inREADME.md.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.